chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm - Issue 257003004: Remove dependency on bookmark_model_factory from bookmark_test_helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm

Issue 257003004: Remove dependency on bookmark_model_factory from bookmark_test_helpers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364433

Patch Set: Fix unit tests on Linux & Windows Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm

index 9b36c197daaddf57eb33ade9dc14d2360eb7611a..67d06c783ef64427d9ee25135550efa27489569d 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm

@@ -158,7 +158,8 @@ TEST_F(BookmarkBarFolderViewTest, BookmarkButtonDragAndDropAcrossProfiles) {

TestingProfile* other_profile =

testing_profile_manager()->CreateTestingProfile("other");

other_profile->CreateBookmarkModel(true);

- test::WaitForBookmarkModelToLoad(other_profile);

+ test::WaitForBookmarkModelToLoad(

+ BookmarkModelFactory::GetForProfile(other_profile));

mock_controller_.reset(GetMockController(

YES, BookmarkModelFactory::GetForProfile(other_profile)));

« no previous file with comments | « chrome/browser/history/in_memory_url_index_unittest.cc ('k') | chrome/browser/ui/cocoa/cocoa_profile_test.mm » ('j') | no next file with comments »