Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 25700010: Implement ArrayBuffer.isView. (Closed)

Created:
7 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/arraybuffer.js View 2 chunks +8 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL.
7 years, 2 months ago (2013-10-04 14:10:42 UTC) #1
rossberg
lgtm
7 years, 2 months ago (2013-10-08 14:52:10 UTC) #2
Dmitry Lomov (no reviews)
7 years, 2 months ago (2013-10-10 09:13:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698