Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2569993003: Low risk non-nullable => nullable change (Closed)
Patch Set: Added fix for Window# top attribute and parent attribute Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Window.idl
diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl
index bb18c335e36dd38b5cf5f358e996fcb25fc77832..265cc88a4da44333415a9417802ec6cc61b6fe94 100644
--- a/third_party/WebKit/Source/core/frame/Window.idl
+++ b/third_party/WebKit/Source/core/frame/Window.idl
@@ -56,10 +56,10 @@
// other browsing contexts
[Replaceable, CallWith=ScriptState, CrossOrigin] readonly attribute Window frames;
[Replaceable, CrossOrigin] readonly attribute unsigned long length;
- [Unforgeable, CrossOrigin] readonly attribute Window top;
+ [Unforgeable, CrossOrigin] readonly attribute Window? top;
// FIXME: opener should be of type any.
[CrossOrigin, Custom=Setter] attribute Window opener;
- [Replaceable, CrossOrigin] readonly attribute Window parent;
+ [Replaceable, CrossOrigin] readonly attribute Window? parent;
[CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frameElement;
// FIXME: open() should have 4 optional arguments with defaults.
[Custom] Window? open(DOMString url, DOMString target, optional DOMString features);

Powered by Google App Engine
This is Rietveld 408576698