Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 2569993002: [ServiceWorker] Mojofy PushEvent of Service Worker. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index a5daba0afd1e1d06eabaf421c2547f95a93af563..01cf40d250c446516edd5d79e9ffe667d54a7b7a 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -179,6 +179,13 @@ class EmbeddedWorkerTestHelper::MockServiceWorkerEventDispatcher
std::move(preload_handle), callback);
}
+ void DispatchPushEvent(const PushEventPayload& payload,
+ const DispatchPushEventCallback& callback) override {
+ if (!helper_)
+ return;
+ helper_->OnPushEventStub(payload, callback);
+ }
+
void DispatchSyncEvent(
const std::string& tag,
blink::mojom::BackgroundSyncEventLastChance last_chance,
@@ -313,7 +320,6 @@ bool EmbeddedWorkerTestHelper::OnMessageToWorker(int thread_id,
IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerTestHelper, message)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ActivateEvent, OnActivateEventStub)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEventStub)
- IPC_MESSAGE_HANDLER(ServiceWorkerMsg_PushEvent, OnPushEventStub)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
// Record all messages directed to inner script context.
@@ -374,12 +380,11 @@ void EmbeddedWorkerTestHelper::OnFetchEvent(
callback.Run(SERVICE_WORKER_OK, base::Time::Now());
}
-void EmbeddedWorkerTestHelper::OnPushEvent(int embedded_worker_id,
- int request_id,
- const PushEventPayload& payload) {
- SimulateSend(new ServiceWorkerHostMsg_PushEventFinished(
- embedded_worker_id, request_id,
- blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
+void EmbeddedWorkerTestHelper::OnPushEvent(
+ const PushEventPayload& payload,
+ const mojom::ServiceWorkerEventDispatcher::DispatchPushEventCallback&
+ callback) {
+ callback.Run(SERVICE_WORKER_OK, base::Time::Now());
}
void EmbeddedWorkerTestHelper::SimulateWorkerReadyForInspection(
@@ -530,11 +535,12 @@ void EmbeddedWorkerTestHelper::OnFetchEventStub(
}
void EmbeddedWorkerTestHelper::OnPushEventStub(
- int request_id,
- const PushEventPayload& payload) {
+ const PushEventPayload& payload,
+ const mojom::ServiceWorkerEventDispatcher::DispatchPushEventCallback&
+ callback) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&EmbeddedWorkerTestHelper::OnPushEvent, AsWeakPtr(),
- current_embedded_worker_id_, request_id, payload));
+ payload, callback));
}
EmbeddedWorkerRegistry* EmbeddedWorkerTestHelper::registry() {

Powered by Google App Engine
This is Rietveld 408576698