Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 2569953003: [bgmode] Log the unpin stack trace to Crash Keys (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index ace2dd1165390eff49e9720bffa9c943afbf6e5e..9426a94f8d1382724c969b07cc08ace6522d0c83 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -15,7 +15,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/command_line.h"
-#include "base/debug/alias.h"
+#include "base/debug/crash_logging.h"
#include "base/debug/leak_annotations.h"
#include "base/files/file_path.h"
#include "base/location.h"
@@ -77,6 +77,7 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/crash_keys.h"
#include "chrome/common/extensions/chrome_extensions_client.h"
#include "chrome/common/extensions/extension_process_policy.h"
#include "chrome/common/features.h"
@@ -1314,10 +1315,9 @@ void BrowserProcessImpl::Pin() {
// CHECK(!IsShuttingDown());
if (IsShuttingDown()) {
- // Copy the stacktrace which released the final reference onto our stack so
- // it will be available in the crash report for inspection.
- base::debug::StackTrace callstack = release_last_reference_callstack_;
- base::debug::Alias(&callstack);
+ // TODO(crbug.com/113031, crbug.com/625646): Temporary instrumentation.
+ base::debug::SetCrashKeyToStackTrace(crash_keys::kBrowserUnpinTrace,
+ release_last_reference_callstack_);
CHECK(false);
}
}
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698