Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic.cc

Issue 256993003: Remove some remnants of MaybeObjects in objects.*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1927 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 1938
1939 // Check the object has run out out property space. 1939 // Check the object has run out out property space.
1940 ASSERT(object->HasFastProperties()); 1940 ASSERT(object->HasFastProperties());
1941 ASSERT(object->map()->unused_property_fields() == 0); 1941 ASSERT(object->map()->unused_property_fields() == 0);
1942 1942
1943 // Expand the properties array. 1943 // Expand the properties array.
1944 Handle<FixedArray> old_storage = handle(object->properties(), isolate); 1944 Handle<FixedArray> old_storage = handle(object->properties(), isolate);
1945 int new_unused = transition->unused_property_fields(); 1945 int new_unused = transition->unused_property_fields();
1946 int new_size = old_storage->length() + new_unused + 1; 1946 int new_size = old_storage->length() + new_unused + 1;
1947 1947
1948 Handle<FixedArray> new_storage = isolate->factory()->CopySizeFixedArray( 1948 Handle<FixedArray> new_storage = FixedArray::CopySize(old_storage, new_size);
1949 old_storage, new_size);
1950 1949
1951 Handle<Object> to_store = value; 1950 Handle<Object> to_store = value;
1952 1951
1953 PropertyDetails details = transition->instance_descriptors()->GetDetails( 1952 PropertyDetails details = transition->instance_descriptors()->GetDetails(
1954 transition->LastAdded()); 1953 transition->LastAdded());
1955 if (details.representation().IsDouble()) { 1954 if (details.representation().IsDouble()) {
1956 to_store = isolate->factory()->NewHeapNumber(value->Number()); 1955 to_store = isolate->factory()->NewHeapNumber(value->Number());
1957 } 1956 }
1958 1957
1959 new_storage->set(old_storage->length(), *to_store); 1958 new_storage->set(old_storage->length(), *to_store);
(...skipping 987 matching lines...) Expand 10 before | Expand all | Expand 10 after
2947 #undef ADDR 2946 #undef ADDR
2948 }; 2947 };
2949 2948
2950 2949
2951 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2950 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2952 return IC_utilities[id]; 2951 return IC_utilities[id];
2953 } 2952 }
2954 2953
2955 2954
2956 } } // namespace v8::internal 2955 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698