Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256993003: Remove some remnants of MaybeObjects in objects.*. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove some remnants of MaybeObjects in objects.*. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21027

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -153 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 2 chunks +3 lines, -11 lines 0 comments Download
M src/factory.cc View 2 chunks +17 lines, -36 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 8 chunks +7 lines, -21 lines 0 comments Download
M src/objects.cc View 1 6 chunks +40 lines, -39 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +0 lines, -36 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 7 months ago (2014-04-28 14:17:29 UTC) #1
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/256993003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/256993003/diff/1/src/objects.cc#newcode8437 src/objects.cc:8437: WriteBarrierMode mode = result->GetWriteBarrierMode(no_gc); OMG, I just looked ...
6 years, 7 months ago (2014-04-28 15:25:23 UTC) #2
Yang
https://codereview.chromium.org/256993003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/256993003/diff/1/src/objects.h#newcode3063 src/objects.h:3063: // Copy operations. On 2014/04/28 15:25:24, Hannes Payer wrote: ...
6 years, 7 months ago (2014-04-28 15:32:18 UTC) #3
Yang
6 years, 7 months ago (2014-04-28 15:33:40 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r21027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698