base/time/time.cc - Issue 2569913003: [base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/time/time.cc

Issue 2569913003: [base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded (Closed)

Patch Set: fix "control can reach out of... " Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/time/time.cc

diff --git a/base/time/time.cc b/base/time/time.cc

index df3942cc858c5ecc7277a3a5db4e02cc0b946ccb..f5cefd49e0a2591b2656d55efeee7b62193f3551 100644

--- a/base/time/time.cc

+++ b/base/time/time.cc

@@ -235,7 +235,12 @@ Time Time::LocalMidnight() const {

exploded.minute = 0;

exploded.second = 0;

exploded.millisecond = 0;

- return FromLocalExploded(exploded);

+ Time out_time;

+ if (FromLocalExploded(exploded, &out_time))

+ return out_time;

+ // This function must not fail.

maksims (do not use this acc) 2016/12/13 11:43:55 miu, How do you think? Should a return value from

+ NOTREACHED();

+ return Time();

}

// static

« no previous file with comments | « base/time/time.h ('k') | google_apis/drive/drive_api_requests_unittest.cc » ('j') | no next file with comments »