Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2569873002: relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes Quantization. (Closed)

Created:
4 years ago by Zhongyi Shi
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes Quantization. Due to an unfortunate ordering of operations in the actual "cubing" part of the CWND calculation, we were inadvertantly quantizing the congestion-window calculation. (Note: The "reno" part of the cubic algorithm wis smooth and not quantized before.) Switching the order of operations obviates the problem. Additionally, removed parameterization from cubic_test.cc and cubic_bytes_test.cc, because the parameterization was getting unwieldy. Instead, the parameters are controlled by command-line flag. Merge internal change: 141183279 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -55 lines) Patch
M net/quic/core/congestion_control/cubic_bytes.h View 3 chunks +12 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.cc View 3 chunks +14 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes_test.cc View 9 chunks +112 lines, -44 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_test.cc View 3 chunks +26 lines, -8 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (5 generated)
Zhongyi Shi
4 years ago (2016-12-13 02:38:57 UTC) #6
Ryan Hamilton
4 years ago (2016-12-13 03:51:22 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698