Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/cronet/android/api/src/org/chromium/net/UrlRequest.java

Issue 2569863002: [Cronet] Remove deprecated UrlRequestException. (Closed)
Patch Set: Update api.txt Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/UrlRequest.java
diff --git a/components/cronet/android/api/src/org/chromium/net/UrlRequest.java b/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
index 726e10ecb62557ab07b5d07281ad81c13e5d10f6..cf5250ab6b3a3d1189253503fd821697f5d099a9 100644
--- a/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
+++ b/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
@@ -214,11 +214,8 @@ public abstract class UrlRequest {
* received.
* @param error information about error.
*/
- public void onFailed(UrlRequest request, UrlResponseInfo info, CronetException error) {
- // TODO(mef): Remove fallback to legacy api and make this method abstract
- // after complete transition to CronetException.
- onFailed(request, info, new UrlRequestException(error));
- }
+ public abstract void onFailed(
+ UrlRequest request, UrlResponseInfo info, CronetException error);
/**
* Invoked if request was canceled via {@link UrlRequest#cancel}. Once
@@ -230,16 +227,6 @@ public abstract class UrlRequest {
* received.
*/
public void onCanceled(UrlRequest request, UrlResponseInfo info) {}
-
- /**
- * @deprecated Use {@code onFailed} instead.
- * {@hide This method will be removed after complete transition to CronetException}.
- */
- @Deprecated
- // TODO(mef): Remove this after complete transition to CronetException.
- public void onFailed(UrlRequest request, UrlResponseInfo info, UrlRequestException error) {
- assert false;
- }
}
/**
« no previous file with comments | « components/cronet/android/api.txt ('k') | components/cronet/android/api/src/org/chromium/net/UrlRequestException.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698