Issue 256983002: Change concurrent sweeping CHECKs to ASSERTs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256983002: Change concurrent sweeping CHECKs to ASSERTs. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Change concurrent sweeping CHECKs to ASSERTs. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21019

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -22 lines)			Patch
	M	src/mark-compact.cc	View	1	5 chunks	+8 lines, -18 lines	0 comments	Download
	M	src/spaces.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nit. https://codereview.chromium.org/256983002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/256983002/diff/1/src/mark-compact.cc#newcode3187 src/mark-compact.cc:3187: p->IsFlagSet(Page::RESCAN_ON_EVACUATION)); nit: Indentation is off.

6 years, 7 months ago (2014-04-28 12:53:03 UTC) #1

Hannes Payer (out of office)

https://codereview.chromium.org/256983002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/256983002/diff/1/src/mark-compact.cc#newcode3187 src/mark-compact.cc:3187: p->IsFlagSet(Page::RESCAN_ON_EVACUATION)); On 2014/04/28 12:53:03, Michael Starzinger wrote: > nit: ...

6 years, 7 months ago (2014-04-28 13:20:30 UTC) #2

Hannes Payer (out of office)

6 years, 7 months ago (2014-04-28 13:20:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21019 (presubmit successful).

Expand Messages | Collapse Messages

Issue 256983002: Change concurrent sweeping CHECKs to ASSERTs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages