Issue 25698003: Implement lookupMember for type variables.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -30 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2 3 4 5	3 chunks	+21 lines, -18 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	1 2 3 4 5	2 chunks	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/25698003/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/25698003/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode408 sdk/lib/_internal/compiler/implementation/typechecker.dart:408: Member member = type.lookupMember(name, Remove lookupMember from DartType ...

7 years, 2 months ago (2013-10-03 09:12:09 UTC) #2

karlklose

Thanks Johnni. https://codereview.chromium.org/25698003/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/25698003/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode408 sdk/lib/_internal/compiler/implementation/typechecker.dart:408: Member member = type.lookupMember(name, Done.

7 years, 2 months ago (2013-10-03 11:13:47 UTC) #3

Emily Fortuna

Thanks, for the quick fix, Karl! Let me know when this gets in and I ...

7 years, 2 months ago (2013-10-03 21:21:01 UTC) #4

Johnni Winther

lgtm https://codereview.chromium.org/25698003/diff/17001/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/25698003/diff/17001/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode573 sdk/lib/_internal/compiler/implementation/typechecker.dart:573: if (identical(receiverKind, TypeKind.TYPEDEF)) { Remove this? (And add ...

7 years, 2 months ago (2013-10-04 07:41:27 UTC) #5

karlklose

https://codereview.chromium.org/25698003/diff/17001/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/25698003/diff/17001/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode573 sdk/lib/_internal/compiler/implementation/typechecker.dart:573: if (identical(receiverKind, TypeKind.TYPEDEF)) { On 2013/10/04 07:41:28, Johnni Winther ...

7 years, 2 months ago (2013-10-04 08:14:23 UTC) #6

karlklose

7 years, 2 months ago (2013-10-04 08:14:47 UTC) #7

Message was sent while issue was closed.

Committed patchset #6 manually as r28252 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25698003: Implement lookupMember for type variables. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove DartType.lookupMember. #

Patch Set 4 : Also handle functions and typedef types. #

Patch Set 5 : Also handle void. #

Patch Set 6 : Address comments, add tests. #

Messages