Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: tools/gn/secondary/skia/BUILD.gn

Issue 25698002: (mostly) working wtf / wtf_unittests gn targets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: formatting Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/base/BUILD.gn ('k') | tools/gn/secondary/testing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/skia/BUILD.gn
diff --git a/tools/gn/secondary/skia/BUILD.gn b/tools/gn/secondary/skia/BUILD.gn
index 0ce32ade25bb803800bc5376230b91d814b9f199..2bca7a8222b7e38f7b196c72c8b34fdf87b51a5a 100644
--- a/tools/gn/secondary/skia/BUILD.gn
+++ b/tools/gn/secondary/skia/BUILD.gn
@@ -1340,9 +1340,6 @@ static_library("skia_opts_ssse3") {
if (is_linux) {
cflags = [ "-msse3" ]
} else if (is_mac) {
- assert(false, "TODO(brettw) write this")
- # 'xcode_settings': {
- # 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES',
- # },
+ cflags = [ "-mssse3" ] # Note the third 's'.
}
}
« no previous file with comments | « tools/gn/secondary/base/BUILD.gn ('k') | tools/gn/secondary/testing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698