Fix SysTray focus rect position

ash/common/system/tray/tray_background_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_background_view.h"
 
 #include <algorithm>
 
 #include "ash/common/ash_constants.h"
 #include "ash/common/material_design/material_design_controller.h"
@@ skipping 554 matching lines @@
   // When an action is performed, ink drop ripple is handled in SetIsActive().
   if (action_performed)
     return;
   ActionableView::HandlePerformActionResult(action_performed, event);
 }
 
 gfx::Rect TrayBackgroundView::GetFocusBounds() {
   // The tray itself expands to the right and bottom edge of the screen to make
   // sure clicking on the edges brings up the popup. However, the focus border
   // should be only around the container.
-  return GetContentsBounds();
+  return MaterialDesignController::IsShelfMaterial() ? GetBackgroundBounds()
+                                                     : GetContentsBounds();
 }
 
 void TrayBackgroundView::OnPaintFocus(gfx::Canvas* canvas) {
   gfx::RectF paint_bounds(GetFocusBounds());
-  paint_bounds.Inset(gfx::Insets(2, -2));
+  paint_bounds.Inset(gfx::Insets(MaterialDesignController::IsShelfMaterial()
+                                     ? -kFocusBorderThickness

[Evan Stade, 2016/12/15 17:38:00]

this looks much better, but GetFocusBounds is still confusing. It looks like
it's a virtual function on ActionableView but the override in TrayBackgroundView
is never actually used (in the sense that ActionableView::OnPaintFocus, which
would use the specialization, is also overridden). I think you should be able to
just get rid of GetFocusBounds and calculate the proper bounds in this function
(i.e. GetBackgroundsBounds() and the appropriate inset)

[Greg Levin, 2016/12/15 21:08:57]

Done.  Also got rid of ActionableView::GetFocusBounds(), since it wasn't being
overridden anywhere.

+                                     : 1));
   canvas->DrawSolidFocusRect(paint_bounds, kFocusBorderColor,
                              kFocusBorderThickness);
 }
 
 void TrayBackgroundView::OnPaint(gfx::Canvas* canvas) {
   ActionableView::OnPaint(canvas);
   if (!MaterialDesignController::IsShelfMaterial() ||
       shelf()->GetBackgroundType() ==
           ShelfBackgroundType::SHELF_BACKGROUND_DEFAULT ||
       !is_separator_visible_) {
@@ skipping 46 matching lines @@
 }
 
 gfx::Rect TrayBackgroundView::GetBackgroundBounds() const {
   gfx::Insets insets = GetBackgroundInsets();
   gfx::Rect bounds = GetLocalBounds();
   bounds.Inset(insets);
   return bounds;
 }
 
 }  // namespace ash