Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

Issue 2569693002: Introduce performance measurement varitation parameter for SubresourceFilter. (Closed)
Patch Set: Clip measurement rate to [0,1]. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_features_test_support.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
diff --git a/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc b/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
index 51a3d58c827637b3e79ee87131d05ec9d70db3c7..d2ab51d073e1b9104cf608caf606841444be5957 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
+++ b/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
@@ -183,4 +183,40 @@ TEST(SubresourceFilterFeaturesTest, ActivationList) {
}
}
+TEST(SubresourceFilterFeaturesTest, PerfMeasurementRate) {
+ const struct {
+ bool feature_enabled;
+ const char* perf_measurement_param;
+ double expected_perf_measurement_rate;
+ } kTestCases[] = {{false, "not_a_number", 0},
+ {false, "0", 0},
+ {false, "1", 0},
+ {true, "not_a_number", 0},
+ {true, "0.5not_a_number", 0},
+ {true, "0", 0},
+ {true, "0.000", 0},
+ {true, "0.05", 0.05},
+ {true, "0.5", 0.5},
+ {true, "1", 1},
+ {true, "1.0", 1},
+ {true, "0.333", 0.333},
+ {true, "1e0", 1}};
+
+ for (const auto& test_case : kTestCases) {
+ SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
+ SCOPED_TRACE(::testing::Message("PerfMeasurementParam = \"")
+ << test_case.perf_measurement_param << "\"");
+
+ base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
+ testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+ test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
+ : base::FeatureList::OVERRIDE_USE_DEFAULT,
+ {{kPerformanceMeasurementRateParameterName,
+ test_case.perf_measurement_param}});
+
+ EXPECT_EQ(test_case.expected_perf_measurement_rate,
+ GetPerformanceMeasurementRate());
+ }
+}
+
} // namespace subresource_filter
« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_features_test_support.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698