components/subresource_filter/core/browser/subresource_filter_features_test_support.cc - Issue 2569693002: Introduce performance measurement varitation parameter for SubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

Issue 2569693002: Introduce performance measurement varitation parameter for SubresourceFilter. (Closed)

Patch Set: Change include. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/core/browser/subresource_filter_features.cc ('K') | « components/subresource_filter/core/browser/subresource_filter_features_test_support.h ('k') | components/subresource_filter/core/browser/subresource_filter_features_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

index 5396c019832021cebb54721bcf60fcb1c65828cb..c3710988dbf91be9c2ffe916e7d2e063e79eca81 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

@@ -33,13 +33,18 @@ ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(

base::FeatureList::OverrideState feature_state,

const std::string& maximum_activation_state,

const std::string& activation_scope,

- const std::string& activation_lists) {

+ const std::string& activation_lists)

+ : ScopedSubresourceFilterFeatureToggle(

+ feature_state,

+ {{kActivationStateParameterName, maximum_activation_state},

+ {kActivationScopeParameterName, activation_scope},

+ {kActivationListsParameterName, activation_lists}}) {}

+ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(

+ base::FeatureList::OverrideState feature_state,

+ std::map<std::string, std::string> variation_params) {

variations::testing::ClearAllVariationParams();

- std::map<std::string, std::string> variation_params;

- variation_params[kActivationStateParameterName] = maximum_activation_state;

- variation_params[kActivationScopeParameterName] = activation_scope;

- variation_params[kActivationListsParameterName] = activation_lists;

EXPECT_TRUE(variations::AssociateVariationParams(

kTestFieldTrialName, kTestExperimentGroupName, variation_params));