third_party/WebKit/Source/core/frame/History.idl - Issue 2569663005: Low risk nullable => non-nullable change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/History.idl

Issue 2569663005: Low risk nullable => non-nullable change (Closed)

Patch Set: Revert CSSStyleDeclaration.idl to pass layout tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/History.idl

diff --git a/third_party/WebKit/Source/core/frame/History.idl b/third_party/WebKit/Source/core/frame/History.idl

index fef8e1fdbaa62510270b50b6b93da475f753e3eb..6add189d4a92cf6cd8d6d1b5fe3d0655200c44e9 100644

--- a/third_party/WebKit/Source/core/frame/History.idl

+++ b/third_party/WebKit/Source/core/frame/History.idl

@@ -35,8 +35,6 @@ interface History {

[CallWith=ExecutionContext] void go(optional long delta = 0);

[CallWith=ExecutionContext] void back();

[CallWith=ExecutionContext] void forward();

- // TODO(foolip): The SerializedScriptValue types should be any.

- // TODO(foolip): The title arguments should not be nullable.

- [RaisesException] void pushState(SerializedScriptValue data, DOMString? title, optional DOMString? url = null);

- [RaisesException] void replaceState(SerializedScriptValue data, DOMString? title, optional DOMString? url = null);

+ [RaisesException] void pushState(SerializedScriptValue data, DOMString title, optional DOMString? url = null);

+ [RaisesException] void replaceState(SerializedScriptValue data, DOMString title, optional DOMString? url = null);

};