Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

Issue 2569663005: Low risk nullable => non-nullable change (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl
diff --git a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl
index 630aea05009f1dbaef3ba42e49a8107af367189b..4a0cfc7fcc29929db3d4ed0c918f1784d5435173 100644
--- a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl
+++ b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl
@@ -31,7 +31,7 @@
DOMString getPropertyPriority(DOMString property);
// TODO(foolip): The value and priority arguments should have
// [TreatNullAs=EmptyString] and should not be nullable.
- [CEReactions, RaisesException] void setProperty(DOMString property, DOMString? value, optional DOMString? priority = null);
+ [CEReactions, RaisesException] void setProperty(DOMString property, DOMString value, optional DOMString priority = null);
foolip 2016/12/13 22:43:24 Here I think we should be adding [TreatNullAs=Empt
lunalu1 2016/12/14 11:04:24 Done.
// void setPropertyValue(DOMString property, [TreatNullAs=EmptyString] DOMString value);
// void setPropertyPriority(DOMString property, [TreatNullAs=EmptyString] DOMString priority);
[CEReactions, RaisesException] DOMString removeProperty(DOMString property);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/History.idl » ('j') | third_party/WebKit/Source/core/frame/History.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698