Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

Issue 2569663005: Low risk nullable => non-nullable change (Closed)
Patch Set: Codereview update Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/History.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 12 matching lines...) Expand all
23 [ 23 [
24 DependentLifetime, 24 DependentLifetime,
25 SetWrapperReferenceTo(CSSRule parentRule), 25 SetWrapperReferenceTo(CSSRule parentRule),
26 ] interface CSSStyleDeclaration { 26 ] interface CSSStyleDeclaration {
27 [CEReactions, RaisesException=Setter] attribute DOMString cssText; 27 [CEReactions, RaisesException=Setter] attribute DOMString cssText;
28 readonly attribute unsigned long length; 28 readonly attribute unsigned long length;
29 getter DOMString item(unsigned long index); 29 getter DOMString item(unsigned long index);
30 DOMString getPropertyValue(DOMString property); 30 DOMString getPropertyValue(DOMString property);
31 DOMString getPropertyPriority(DOMString property); 31 DOMString getPropertyPriority(DOMString property);
32 // TODO(foolip): The value and priority arguments should have 32 // TODO(foolip): The value and priority arguments should have
33 // [TreatNullAs=EmptyString] and should not be nullable. 33 // [TreatNullAs=EmptyString] and should not be nullable.
foolip 2016/12/14 12:07:00 Can remove the TODO now. Tests needed.
lunalu1 2016/12/14 13:59:04 Done.
34 [CEReactions, RaisesException] void setProperty(DOMString property, DOMStrin g? value, optional DOMString? priority = null); 34 [CEReactions, RaisesException] void setProperty(DOMString property, [TreatNu llAs=EmptyString] DOMString value, [TreatNullAs=EmptyString] optional DOMString priority = "");
35 // void setPropertyValue(DOMString property, [TreatNullAs=EmptyString] DOMSt ring value); 35 // void setPropertyValue(DOMString property, [TreatNullAs=EmptyString] DOMSt ring value);
36 // void setPropertyPriority(DOMString property, [TreatNullAs=EmptyString] DO MString priority); 36 // void setPropertyPriority(DOMString property, [TreatNullAs=EmptyString] DO MString priority);
37 [CEReactions, RaisesException] DOMString removeProperty(DOMString property); 37 [CEReactions, RaisesException] DOMString removeProperty(DOMString property);
38 readonly attribute CSSRule? parentRule; 38 readonly attribute CSSRule? parentRule;
39 [CEReactions, RaisesException=Setter, TreatNullAs=EmptyString] attribute DOM String cssFloat; 39 [CEReactions, RaisesException=Setter, TreatNullAs=EmptyString] attribute DOM String cssFloat;
40 40
41 // The camel-cased and dashed attribute getters have custom bindings. 41 // The camel-cased and dashed attribute getters have custom bindings.
42 // https://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-camel-cased-attri bute 42 // https://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-camel-cased-attri bute
43 // https://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-dashed-attribute 43 // https://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-dashed-attribute
44 [Custom=(PropertyGetter,PropertyEnumerator,PropertyQuery)] getter (DOMString or float) (DOMString name); 44 [Custom=(PropertyGetter,PropertyEnumerator,PropertyQuery)] getter (DOMString or float) (DOMString name);
45 [Custom] setter void (DOMString property, DOMString? propertyValue); 45 [Custom] setter void (DOMString property, DOMString? propertyValue);
46 }; 46 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/History.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698