third_party/WebKit/Source/modules/gamepad/GamepadEventInit.idl - Issue 2569663005: Low risk nullable => non-nullable change

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/gamepad/GamepadEventInit.idl

Issue 2569663005: Low risk nullable => non-nullable change (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/gamepad/#gamepadevent-interface	5 // https://w3c.github.io/gamepad/#gamepadevent-interface

6	6

7 dictionary GamepadEventInit : EventInit {	7 dictionary GamepadEventInit : EventInit {

8 // TODO(foolip): \|gamepad\| should be required and not nullable.	8 // TODO(foolip): \|gamepad\| should be required and not nullable.
	foolip 2016/12/13 22:43:24 I think that the whole set of changes around gamep I think that the whole set of changes around gamepad on GamepadEvent and GamepadEventInit would go well together. lunalu1 2016/12/14 11:04:24 Done. Show quoted text On 2016/12/13 22:43:24, foolip wrote: > I think that the whole set of changes around gamepad on GamepadEvent and > GamepadEventInit would go well together. Done.
9 // https://crbug.com/647693	9 // https://crbug.com/647693

10 // https://github.com/w3c/gamepad/issues/35	10 // https://github.com/w3c/gamepad/issues/35

11 Gamepad? gamepad;	11 Gamepad gamepad;

12 };	12 };

OLD	NEW