third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl - Issue 2569663005: Low risk nullable => non-nullable change

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl

Issue 2569663005: Low risk nullable => non-nullable change (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/frame/History.idl ('K') | « third_party/WebKit/Source/core/frame/History.idl ('k') | third_party/WebKit/Source/modules/gamepad/GamepadEventInit.idl » ('j') | third_party/WebKit/Source/modules/gamepad/GamepadEventInit.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://html.spec.whatwg.org/#imagebitmapoptions	5 // https://html.spec.whatwg.org/#imagebitmapoptions

6	6

7 enum ImageOrientation { "none", "flipY" };	7 enum ImageOrientation { "none", "flipY" };

8 enum PremultiplyAlpha { "none", "premultiply", "default" };	8 enum PremultiplyAlpha { "none", "premultiply", "default" };

9 enum CanvasColorSpace { "none", "default", "srgb", "linear-rgb" };	9 enum CanvasColorSpace { "none", "default", "srgb", "linear-rgb" };

10 [RuntimeEnabled=ExperimentalCanvasFeatures] enum ResizeQuality { "pixelated", "l ow", "medium", "high" };	10 [RuntimeEnabled=ExperimentalCanvasFeatures] enum ResizeQuality { "pixelated", "l ow", "medium", "high" };

11 dictionary ImageBitmapOptions {	11 dictionary ImageBitmapOptions {

12 ImageOrientation imageOrientation = "none";	12 ImageOrientation imageOrientation = "none";

13 PremultiplyAlpha premultiplyAlpha = "default";	13 PremultiplyAlpha premultiplyAlpha = "default";

14 CanvasColorSpace colorSpaceConversion = "default";	14 CanvasColorSpace colorSpaceConversion = "default";

15 [RuntimeEnabled=ExperimentalCanvasFeatures, EnforceRange] unsigned long? res izeWidth;	15 [RuntimeEnabled=ExperimentalCanvasFeatures, EnforceRange] unsigned long resi zeWidth;
	foolip 2016/12/13 22:43:24 Let's take a look at the change in the generated c Let's take a look at the change in the generated code tomorrow to figure out if this can be tested or not. lunalu1 2016/12/14 11:04:24 Done. Show quoted text On 2016/12/13 22:43:24, foolip wrote: > Let's take a look at the change in the generated code tomorrow to figure out if > this can be tested or not. Done.
16 [RuntimeEnabled=ExperimentalCanvasFeatures, EnforceRange] unsigned long? res izeHeight;	16 [RuntimeEnabled=ExperimentalCanvasFeatures, EnforceRange] unsigned long resi zeHeight;

17 [RuntimeEnabled=ExperimentalCanvasFeatures] ResizeQuality resizeQuality = "l ow";	17 [RuntimeEnabled=ExperimentalCanvasFeatures] ResizeQuality resizeQuality = "l ow";

18 };	18 };

OLD	NEW