Issue 2569623002: Renames and comment tweaks for files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2569623002: Renames and comment tweaks for files. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Renames and comment tweaks for files. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4fa34135963cc422dfe52726d2b18e3353863999

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -20 lines)			Patch
M	pkg/analysis_server/lib/src/context_manager.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	8 chunks	+12 lines, -16 lines	1 comment	Download
M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2569623002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2569623002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode140 pkg/analyzer/lib/src/dart/analysis/driver.dart:140: * The set of added files. "explicitly added"?

4 years ago (2016-12-11 16:40:04 UTC) #2

scheglov

4 years ago (2016-12-11 18:11:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4fa34135963cc422dfe52726d2b18e3353863999 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages