Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 2039 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2050 context = UseRegister(instr->context()); | 2050 context = UseRegister(instr->context()); |
| 2051 value = UseRegister(instr->value()); | 2051 value = UseRegister(instr->value()); |
| 2052 temp = NULL; | 2052 temp = NULL; |
| 2053 } | 2053 } |
| 2054 LInstruction* result = new(zone()) LStoreContextSlot(context, value, temp); | 2054 LInstruction* result = new(zone()) LStoreContextSlot(context, value, temp); |
| 2055 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; | 2055 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; |
| 2056 } | 2056 } |
| 2057 | 2057 |
| 2058 | 2058 |
| 2059 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { | 2059 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { |
| 2060 if (instr->access().IsExternalMemory() && instr->access().offset() == 0) { | 2060 if (instr->access().IsExternalMemory() && |
| 2061 !instr->access().representation().IsSpecialization() && | |
|
mvstanton
2013/10/02 11:13:12
Could you add a comment to summarize this decision
Benedikt Meurer
2013/10/02 11:48:06
Done.
| |
| 2062 instr->access().offset() == 0) { | |
| 2061 LOperand* obj = UseRegisterOrConstantAtStart(instr->object()); | 2063 LOperand* obj = UseRegisterOrConstantAtStart(instr->object()); |
| 2062 return DefineFixed(new(zone()) LLoadNamedField(obj), rax); | 2064 return DefineFixed(new(zone()) LLoadNamedField(obj), rax); |
| 2063 } | 2065 } |
| 2064 LOperand* obj = UseRegisterAtStart(instr->object()); | 2066 LOperand* obj = UseRegisterAtStart(instr->object()); |
| 2065 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); | 2067 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); |
| 2066 } | 2068 } |
| 2067 | 2069 |
| 2068 | 2070 |
| 2069 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) { | 2071 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) { |
| 2070 LOperand* object = UseFixed(instr->object(), rax); | 2072 LOperand* object = UseFixed(instr->object(), rax); |
| (...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2535 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { | 2537 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { |
| 2536 LOperand* object = UseRegister(instr->object()); | 2538 LOperand* object = UseRegister(instr->object()); |
| 2537 LOperand* index = UseTempRegister(instr->index()); | 2539 LOperand* index = UseTempRegister(instr->index()); |
| 2538 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); | 2540 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); |
| 2539 } | 2541 } |
| 2540 | 2542 |
| 2541 | 2543 |
| 2542 } } // namespace v8::internal | 2544 } } // namespace v8::internal |
| 2543 | 2545 |
| 2544 #endif // V8_TARGET_ARCH_X64 | 2546 #endif // V8_TARGET_ARCH_X64 |
| OLD | NEW |