Add support to load/store byte fields.

src/x64/lithium-codegen-x64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2764 matching lines @@
 
   __ bind(&skip_assignment);
 }
 
 
 void LCodeGen::DoLoadNamedField(LLoadNamedField* instr) {
   HObjectAccess access = instr->hydrogen()->access();
   int offset = access.offset();
 
   if (access.IsExternalMemory()) {
-    ASSERT(!access.representation().IsInteger32());
     Register result = ToRegister(instr->result());
     if (instr->object()->IsConstantOperand()) {
       ASSERT(result.is(rax));
+      ASSERT(!access.representation().IsSpecialization());
       __ load_rax(ToExternalReference(LConstantOperand::cast(instr->object())));
     } else {
-      Register object = ToRegister(instr->object());
-      __ movq(result, MemOperand(object, offset));
+      MemOperand operand = MemOperand(ToRegister(instr->object()), offset);

[mvstanton, 2013/10/02 11:13:12]

How about a helper function that does the right move based on representation and
sign-extend like:

void LCodeGen::EmitAppropriateMove(Register result, 
    MemOperand operand,
    Representation representation,
    bool sign_extend);

All four of these locations could benefit from that.

[Benedikt Meurer, 2013/10/02 11:48:06]

Done.

+      if (access.representation().IsByte()) {
+        __ movzxbl(result, operand);
+      } else if (access.representation().IsInteger32()) {
+        __ movl(result, operand);
+      } else {
+        __ movq(result, operand);
+      }
     }
     return;
   }
 
   Register object = ToRegister(instr->object());
   if (FLAG_track_double_fields &&
       instr->hydrogen()->representation().IsDouble()) {
     XMMRegister result = ToDoubleRegister(instr->result());
     __ movsd(result, FieldOperand(object, offset));
     return;
   }
 
   Register result = ToRegister(instr->result());
-  if (access.IsInobject()) {
-    if (access.representation().IsInteger32()) {
-      __ movl(result, FieldOperand(object, offset));
-    } else {
-      __ movq(result, FieldOperand(object, offset));
-    }
+  if (!access.IsInobject()) {
+    __ movq(result, FieldOperand(object, JSObject::kPropertiesOffset));
+    object = result;
+  }
+  MemOperand operand = FieldOperand(object, offset);
+  if (access.representation().IsByte()) {
+    __ movzxbl(result, operand);
+  } else if (access.representation().IsInteger32()) {
+    __ movl(result, operand);
   } else {
-    __ movq(result, FieldOperand(object, JSObject::kPropertiesOffset));
-    if (access.representation().IsInteger32()) {
-      __ movl(result, FieldOperand(result, offset));
-    } else {
-      __ movq(result, FieldOperand(result, offset));
-    }
+    __ movq(result, operand);
   }
 }
 
 
 void LCodeGen::DoLoadNamedGeneric(LLoadNamedGeneric* instr) {
   ASSERT(ToRegister(instr->object()).is(rax));
   ASSERT(ToRegister(instr->result()).is(rax));
 
   __ Move(rcx, instr->name());
   Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
@@ skipping 1098 matching lines @@
 }
 
 
 void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
   Representation representation = instr->representation();
 
   HObjectAccess access = instr->hydrogen()->access();
   int offset = access.offset();
 
   if (access.IsExternalMemory()) {
-    ASSERT(!access.representation().IsInteger32());
     ASSERT(!instr->hydrogen()->NeedsWriteBarrier());
     Register value = ToRegister(instr->value());
     if (instr->object()->IsConstantOperand()) {
       ASSERT(value.is(rax));
+      ASSERT(!access.representation().IsSpecialization());
       LConstantOperand* object = LConstantOperand::cast(instr->object());
       __ store_rax(ToExternalReference(object));
     } else {
-      Register object = ToRegister(instr->object());
-      __ movq(MemOperand(object, offset), value);
+      MemOperand operand = MemOperand(ToRegister(instr->object()), offset);
+      if (representation.IsByte()) {
+        __ movb(operand, value);
+      } else if (representation.IsInteger32()) {
+        __ movl(operand, value);
+      } else {
+        __ movq(operand, value);
+      }
     }
     return;
   }
 
   Register object = ToRegister(instr->object());
   Handle<Map> transition = instr->transition();
 
   if (FLAG_track_fields && representation.IsSmi()) {
     if (instr->value()->IsConstantOperand()) {
       LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
@@ skipping 45 matching lines @@
   SmiCheck check_needed =
       instr->hydrogen()->value()->IsHeapObject()
           ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
 
   Register write_register = object;
   if (!access.IsInobject()) {
     write_register = ToRegister(instr->temp());
     __ movq(write_register, FieldOperand(object, JSObject::kPropertiesOffset));
   }
 
+  MemOperand operand = FieldOperand(write_register, offset);
   if (instr->value()->IsConstantOperand()) {
     LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
     if (operand_value->IsRegister()) {
-      if (access.representation().IsInteger32()) {
-        __ movl(FieldOperand(write_register, offset),
-                ToRegister(operand_value));
+      Register value = ToRegister(operand_value);
+      if (representation.IsByte()) {
+        __ movb(operand, value);
+      } else if (representation.IsInteger32()) {
+        __ movl(operand, value);
       } else {
-        __ movq(FieldOperand(write_register, offset),
-                ToRegister(operand_value));
+        __ movq(operand, value);
       }
     } else {
       Handle<Object> handle_value = ToHandle(operand_value);
       ASSERT(!instr->hydrogen()->NeedsWriteBarrier());
-      __ Move(FieldOperand(write_register, offset), handle_value);
+      __ Move(operand, handle_value);
     }
   } else {
-    if (access.representation().IsInteger32()) {
-      __ movl(FieldOperand(write_register, offset), ToRegister(instr->value()));
+    Register value = ToRegister(instr->value());
+    if (representation.IsByte()) {
+      __ movb(operand, value);
+    } else if (representation.IsInteger32()) {
+      __ movl(operand, value);
     } else {
-      __ movq(FieldOperand(write_register, offset), ToRegister(instr->value()));
+      __ movq(operand, value);
     }
   }
 
   if (instr->hydrogen()->NeedsWriteBarrier()) {
     Register value = ToRegister(instr->value());
     Register temp = access.IsInobject() ? ToRegister(instr->temp()) : object;
     // Update the write barrier for the object for in-object properties.
     __ RecordWriteField(write_register,
                         offset,
                         value,
@@ skipping 1472 matching lines @@
                                FixedArray::kHeaderSize - kPointerSize));
   __ bind(&done);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64