Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
256943003:
SupervisedUserPrefStore: Add pref mapping. (Closed)
|
Created:
6 years, 8 months ago by Marc Treib Modified:
6 years, 7 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews, pam+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionSupervisedUserPrefStore: Add pref mapping.
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266787
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (0 generated)
https://codereview.chromium.org/256943003/diff/1/chrome/browser/managed_mode/... File chrome/browser/managed_mode/supervised_user_pref_store.cc (right): https://codereview.chromium.org/256943003/diff/1/chrome/browser/managed_mode/... chrome/browser/managed_mode/supervised_user_pref_store.cc:43: managed_users::kSigninAllowed, Do you need to declare this somewhere?
On 2014/04/28 09:56:40, Bernhard Bauer wrote: > https://codereview.chromium.org/256943003/diff/1/chrome/browser/managed_mode/... > File chrome/browser/managed_mode/supervised_user_pref_store.cc (right): > > https://codereview.chromium.org/256943003/diff/1/chrome/browser/managed_mode/... > chrome/browser/managed_mode/supervised_user_pref_store.cc:43: > managed_users::kSigninAllowed, > Do you need to declare this somewhere? It's already declared in managed_user_constants.h/cc.
LGTM On 2014/04/28 10:06:34, treib wrote: > On 2014/04/28 09:56:40, Bernhard Bauer wrote: > > > https://codereview.chromium.org/256943003/diff/1/chrome/browser/managed_mode/... > > File chrome/browser/managed_mode/supervised_user_pref_store.cc (right): > > > > > https://codereview.chromium.org/256943003/diff/1/chrome/browser/managed_mode/... > > chrome/browser/managed_mode/supervised_user_pref_store.cc:43: > > managed_users::kSigninAllowed, > > Do you need to declare this somewhere? > > It's already declared in managed_user_constants.h/cc. Huh. Seven-months-ago me was a smart fella!
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/256943003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/256943003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on android_dbg_triggered_tests
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/256943003/1
Message was sent while issue was closed.
Change committed as 266787 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
