Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7074)

Unified Diff: chrome/test/BUILD.gn

Issue 2569333002: Address some TODO(GYP_GONE)s (Closed)
Patch Set: reduce scope a little Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index f4787108188c18eddd07e40cae6c41648b5a15b3..f92fa9438a9fffcbf55f4ea9b0cb04f3d3f6345b 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -250,15 +250,6 @@ static_library("test_support") {
}
}
-# TODO(GYP_GONE): Delete this after we've converted everything to GN.
-# The _run targets exist only for compatibility w/ GYP.
-group("telemetry_gpu_integration_test_run") {
- testonly = true
- deps = [
- ":telemetry_gpu_integration_test",
- ]
-}
-
group("telemetry_gpu_integration_test") {
testonly = true
deps = [
@@ -1097,15 +1088,6 @@ if (!is_android) {
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
}
- # TODO(GYP_GONE): Delete this after we've converted everything to GN.
- # The _run targets exist only for compatibility w/ GYP.
- group("telemetry_unittests_run") {
- testonly = true
- deps = [
- ":telemetry_unittests",
- ]
- }
-
group("telemetry_unittests") {
testonly = true
deps = [
@@ -1158,8 +1140,8 @@ if (!is_android) {
}
# TODO(GYP_GONE): Delete this after we've converted everything to GN.
- # The _run targets exist only for compatibility w/ GYP.
- group("tab_capture_end2end_tests_run") {
+ # This target exist only for compatibility w/ GYP.
+ group("tab_capture_end2end_tests") {
testonly = true
deps = [
":browser_tests",
@@ -2997,15 +2979,6 @@ if (!is_android) {
}
}
-# TODO(GYP_GONE): Delete this after we've converted everything to GN.
-# The _run targets exist only for compatibility w/ GYP.
-group("telemetry_perf_unittests_run") {
- testonly = true
- deps = [
- ":telemetry_perf_unittests",
- ]
-}
-
group("telemetry_perf_unittests") {
testonly = true
deps = [
@@ -5186,15 +5159,6 @@ if (is_android) {
}
if (is_chromeos && enable_package_mash_services) {
- # TODO(GYP_GONE): Delete this after we've converted everything to GN.
- # The _run targets exist only for compatibility w/ GYP.
- group("mash_browser_tests_run") {
- testonly = true
- deps = [
- ":mash_browser_tests",
- ]
- }
-
group("mash_browser_tests") {
testonly = true
data_deps = [

Powered by Google App Engine
This is Rietveld 408576698