Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 256933004: Revert of Add nacl_loader_unittests to the chromium_builder_tests (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Add nacl_loader_unittests to the chromium_builder_tests (https://codereview.chromium.org/260003005/) Reason for revert: Unconditionally adds a nacl dependency, breaks disable_nacl=1 builds Original issue's description: > Add nacl_loader_unittests to the chromium_builder_tests > > TEST=ninja -C out/Release chromium_builder_tests > BUG=364751 > R=hidehiko@chromium.org > TBR=mseaborn@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266521 TBR=hidehiko@chromium.org,mseaborn@chromium.org,hamaji@chromium.org NOTREECHECKS=true NOTRY=true BUG=364751 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Add nacl_loader_unittests to the chromium_builder_tests
6 years, 7 months ago (2014-04-28 13:16:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/256933004/1
6 years, 7 months ago (2014-04-28 13:16:59 UTC) #2
commit-bot: I haz the power
Change committed as 266534
6 years, 7 months ago (2014-04-28 13:18:02 UTC) #3
hamaji
6 years, 7 months ago (2014-04-28 14:12:43 UTC) #4
Message was sent while issue was closed.
On 2014/04/28 13:18:02, I haz the power (commit-bot) wrote:
> Change committed as 266534

Oops, thanks...

Powered by Google App Engine
This is Rietveld 408576698