third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

index 034bde6eb59ccb71de9313dc56472f3e1c98a807..1fca4a5d75a79e9a7735d6cfd3ab5450ae2c26e2 100644

--- a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

@@ -82,9 +82,8 @@ class GetNavigationPolicyTest : public testing::Test {

int modifiers,

WebMouseEvent::Button button,

bool asPopup) {

- WebMouseEvent event;

- event.modifiers = modifiers;

- event.type = WebInputEvent::MouseUp;

+ WebMouseEvent event(WebInputEvent::MouseUp, modifiers,

+ WebInputEvent::TimeStampForTesting);

event.button = button;

setCurrentInputEventForTest(&event);

m_chromeClientImpl->setScrollbarsVisible(!asPopup);