content/browser/renderer_host/input/web_input_event_util_unittest.cc - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_util_unittest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/touch_event_queue.cc ('K') | « content/browser/renderer_host/input/web_input_event_builders_android.cc ('k') | content/browser/renderer_host/native_web_keyboard_event_android.cc » ('j') | content/browser/renderer_host/native_web_keyboard_event_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_util_unittest.cc

diff --git a/content/browser/renderer_host/input/web_input_event_util_unittest.cc b/content/browser/renderer_host/input/web_input_event_util_unittest.cc

index 9dcc3157b7ec72a68b5c0161a11157e3d7c78598..6444f9e2a3123f0ca14f9f4a0465fd924a0905dd 100644

--- a/content/browser/renderer_host/input/web_input_event_util_unittest.cc

+++ b/content/browser/renderer_host/input/web_input_event_util_unittest.cc

@@ -49,12 +49,11 @@ TEST(WebInputEventUtilTest, MotionEventConversion) {

event.set_flags(ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN);

event.set_unique_event_id(123456U);

- WebTouchEvent expected_event;

- expected_event.type = WebInputEvent::TouchStart;

+ WebTouchEvent expected_event(

+ WebInputEvent::TouchStart,

+ WebInputEvent::ShiftKey | WebInputEvent::AltKey,

+ (event.GetEventTime() - base::TimeTicks()).InSecondsF());

expected_event.touchesLength = 1;

- expected_event.timeStampSeconds =

- (event.GetEventTime() - base::TimeTicks()).InSecondsF();

- expected_event.modifiers = WebInputEvent::ShiftKey | WebInputEvent::AltKey;

WebTouchPoint expected_pointer;

expected_pointer.id = pointer.id;

expected_pointer.state = WebTouchPoint::StatePressed;