Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
index a511ed74e80db421206a205f0d3d0d13c4527063..b3d0710e1db869cc7a5bbf44af5fe246a7de8b5d 100644
--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
@@ -142,7 +142,7 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestWheelToFirstScrollHistograms) {
auto wheel = SyntheticWebMouseWheelEventBuilder::Build(
blink::WebMouseWheelEvent::PhaseChanged);
base::TimeTicks now = base::TimeTicks::Now();
- wheel.timeStampSeconds = (now - base::TimeTicks()).InSecondsF();
+ wheel.setTimeStampSeconds((now - base::TimeTicks()).InSecondsF());
ui::LatencyInfo wheel_latency(ui::SourceEventType::WHEEL);
wheel_latency.AddLatencyNumberWithTimestamp(
ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
@@ -219,7 +219,7 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestWheelToScrollHistograms) {
auto wheel = SyntheticWebMouseWheelEventBuilder::Build(
blink::WebMouseWheelEvent::PhaseChanged);
base::TimeTicks now = base::TimeTicks::Now();
- wheel.timeStampSeconds = (now - base::TimeTicks()).InSecondsF();
+ wheel.setTimeStampSeconds((now - base::TimeTicks()).InSecondsF());
ui::LatencyInfo wheel_latency(ui::SourceEventType::WHEEL);
wheel_latency.AddLatencyNumberWithTimestamp(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
@@ -296,7 +296,7 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToFirstScrollHistograms) {
auto scroll = SyntheticWebGestureEventBuilder::BuildScrollUpdate(
5.f, -5.f, 0, blink::WebGestureDeviceTouchscreen);
base::TimeTicks now = base::TimeTicks::Now();
- scroll.timeStampSeconds = (now - base::TimeTicks()).InSecondsF();
+ scroll.setTimeStampSeconds((now - base::TimeTicks()).InSecondsF());
ui::LatencyInfo scroll_latency;
scroll_latency.AddLatencyNumberWithTimestamp(
ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
@@ -430,7 +430,7 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToScrollHistograms) {
auto scroll = SyntheticWebGestureEventBuilder::BuildScrollUpdate(
5.f, -5.f, 0, blink::WebGestureDeviceTouchscreen);
base::TimeTicks now = base::TimeTicks::Now();
- scroll.timeStampSeconds = (now - base::TimeTicks()).InSecondsF();
+ scroll.setTimeStampSeconds((now - base::TimeTicks()).InSecondsF());
ui::LatencyInfo scroll_latency;
scroll_latency.AddLatencyNumberWithTimestamp(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
@@ -680,8 +680,9 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, InputCoordinatesPopulated) {
}
{
- NativeWebKeyboardEvent event;
- event.type = blink::WebKeyboardEvent::KeyDown;
+ NativeWebKeyboardEvent event(blink::WebKeyboardEvent::KeyDown,
+ blink::WebInputEvent::NoModifiers,
+ base::TimeTicks::Now());
ui::LatencyInfo latency_info;
tracker()->OnInputEvent(event, &latency_info);
EXPECT_EQ(0u, latency_info.input_coordinates_size());

Powered by Google App Engine
This is Rietveld 408576698