Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index b14a741cd2243b1cdd955777019c5b69c83d04f8..2c336f38dd10b54a4f9f30f0a7650f2bf16283c6 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -31,6 +31,7 @@
#include "content/public/common/content_switches.h"
#include "gpu/ipc/common/gpu_messages.h"
#include "skia/ext/platform_canvas.h"
+#include "ui/events/base_event_utils.h"
#if defined(OS_MACOSX)
#import "content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h"
@@ -562,16 +563,19 @@ void RenderWidgetHostViewGuest::MaybeSendSyntheticTapGesture(
gfx::Vector2d offset =
GetViewBounds().origin() -
GetOwnerRenderWidgetHostView()->GetBoundsInRootWindow().origin();
- blink::WebGestureEvent gesture_tap_event;
+ blink::WebGestureEvent gesture_tap_event(
+ blink::WebGestureEvent::GestureTapDown,
+ blink::WebInputEvent::NoModifiers,
+ ui::EventTimeStampToSeconds(ui::EventTimeForNow()));
gesture_tap_event.sourceDevice = blink::WebGestureDeviceTouchscreen;
- gesture_tap_event.type = blink::WebGestureEvent::GestureTapDown;
gesture_tap_event.x = position.x + offset.x();
gesture_tap_event.y = position.y + offset.y();
gesture_tap_event.globalX = screenPosition.x;
gesture_tap_event.globalY = screenPosition.y;
GetOwnerRenderWidgetHostView()->ProcessGestureEvent(
gesture_tap_event, ui::LatencyInfo(ui::SourceEventType::TOUCH));
- gesture_tap_event.type = blink::WebGestureEvent::GestureTapCancel;
+
+ gesture_tap_event.setType(blink::WebGestureEvent::GestureTapCancel);
GetOwnerRenderWidgetHostView()->ProcessGestureEvent(
gesture_tap_event, ui::LatencyInfo(ui::SourceEventType::TOUCH));
}

Powered by Google App Engine
This is Rietveld 408576698