blimp/client/core/input/blimp_input_manager.cc - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/input/blimp_input_manager.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/input/blimp_input_manager.cc

diff --git a/blimp/client/core/input/blimp_input_manager.cc b/blimp/client/core/input/blimp_input_manager.cc

index 66c0d0514e3176125c38dbdc99aaf9c0374e0e7d..5b2b3867622fa46062852e0cdac0c58423e38b91 100644

--- a/blimp/client/core/input/blimp_input_manager.cc

+++ b/blimp/client/core/input/blimp_input_manager.cc

@@ -81,7 +81,7 @@ void BlimpInputManager::OnGestureEvent(const ui::GestureEventData& gesture) {

// See crbug.com/443247.

if (web_gesture.type == blink::WebInputEvent::GestureTap &&

web_gesture.modifiers == blink::WebInputEvent::ShiftKey) {

- web_gesture.modifiers = 0;

+ web_gesture.setModifiers(0);

majidvp 2016/12/19 20:09:52 s/0/NoModifiers/

dtapuska 2016/12/20 19:49:21 Done.

}

compositor_task_runner_->PostTask(