Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: ui/events/blink/web_input_event_traits_unittest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/blink/web_input_event_traits_unittest.cc
diff --git a/ui/events/blink/web_input_event_traits_unittest.cc b/ui/events/blink/web_input_event_traits_unittest.cc
index 4b347f1471743234a93dbf95138411d20f8a9ee9..8d566a0dd4c14a6d7dc3715d1efc6f5741c46b85 100644
--- a/ui/events/blink/web_input_event_traits_unittest.cc
+++ b/ui/events/blink/web_input_event_traits_unittest.cc
@@ -23,26 +23,28 @@ using WebInputEventTraitsTest = testing::Test;
// Very basic smoke test to ensure stringification doesn't explode.
TEST_F(WebInputEventTraitsTest, ToString) {
- WebKeyboardEvent key;
- key.type = WebInputEvent::RawKeyDown;
+ WebKeyboardEvent key(WebInputEvent::RawKeyDown, WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
EXPECT_FALSE(WebInputEventTraits::ToString(key).empty());
- WebMouseEvent mouse;
- mouse.type = WebInputEvent::MouseMove;
+ WebMouseEvent mouse(WebInputEvent::MouseMove, WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
EXPECT_FALSE(WebInputEventTraits::ToString(mouse).empty());
- WebMouseWheelEvent mouse_wheel;
- mouse_wheel.type = WebInputEvent::MouseWheel;
+ WebMouseWheelEvent mouse_wheel(WebInputEvent::MouseWheel,
+ WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
EXPECT_FALSE(WebInputEventTraits::ToString(mouse_wheel).empty());
- WebGestureEvent gesture;
- gesture.type = WebInputEvent::GesturePinchBegin;
+ WebGestureEvent gesture(WebInputEvent::GesturePinchBegin,
+ WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
gesture.x = 1;
gesture.y = 1;
EXPECT_FALSE(WebInputEventTraits::ToString(gesture).empty());
- WebTouchEvent touch;
- touch.type = WebInputEvent::TouchStart;
+ WebTouchEvent touch(WebInputEvent::TouchStart, WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
touch.touchesLength = 1;
EXPECT_FALSE(WebInputEventTraits::ToString(touch).empty());
}

Powered by Google App Engine
This is Rietveld 408576698