Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/KeyboardTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp
index b1022135392a0e247a737f0c4830dfd8268be888..e92742e3e9a4c971c65d365a27d75befed07fb72 100644
--- a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp
+++ b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp
@@ -57,9 +57,7 @@ class KeyboardTest : public testing::Test {
int modifiers,
WebInputEvent::Type type,
const String& key = emptyString()) {
- WebKeyboardEvent event;
- event.type = type;
- event.modifiers = modifiers;
+ WebKeyboardEvent event(type, modifiers, WebInputEvent::TimeStampForTesting);
event.text[0] = keyCode;
event.windowsKeyCode = keyCode;
event.domKey = Platform::current()->domKeyEnumFromString(key);

Powered by Google App Engine
This is Rietveld 408576698