Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
index 23b7ffd72a3b42f76c687d2d60988c6c39beb3d4..96d73d23f2f4b6c88138da0a09f4b3c8286363ae 100644
--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
@@ -204,7 +204,7 @@ WebInputEventResult KeyboardEventManager::keyEvent(
WebKeyboardEvent keyDownEvent = initialKeyEvent;
if (keyDownEvent.type != WebInputEvent::RawKeyDown)
- keyDownEvent.type = WebInputEvent::RawKeyDown;
+ keyDownEvent.setType(WebInputEvent::RawKeyDown);
KeyboardEvent* keydown =
KeyboardEvent::create(keyDownEvent, m_frame->document()->domWindow());
if (matchedAnAccessKey)
@@ -244,7 +244,7 @@ WebInputEventResult KeyboardEventManager::keyEvent(
#endif
WebKeyboardEvent keyPressEvent = initialKeyEvent;
- keyPressEvent.type = WebInputEvent::Char;
+ keyPressEvent.setType(WebInputEvent::Char);
if (keyPressEvent.text[0] == 0)
return WebInputEventResult::NotHandled;
KeyboardEvent* keypress =

Powered by Google App Engine
This is Rietveld 408576698