content/browser/renderer_host/render_widget_host_view_event_handler.cc - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_event_handler.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/user_input_tracker_unittest.cc ('K') | « content/browser/renderer_host/render_widget_host_unittest.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_event_handler.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_event_handler.cc b/content/browser/renderer_host/render_widget_host_view_event_handler.cc

index 2adb005ff4b91c9d162c8d2e975830de56955b90..9002372c1d1e3a7db80c69b9b85a4875538440f0 100644

--- a/content/browser/renderer_host/render_widget_host_view_event_handler.cc

+++ b/content/browser/renderer_host/render_widget_host_view_event_handler.cc

@@ -505,7 +505,7 @@ void RenderWidgetHostViewEventHandler::OnGestureEvent(ui::GestureEvent* event) {

// Webkit does not stop a fling-scroll on tap-down. So explicitly send an

// event to stop any in-progress flings.

blink::WebGestureEvent fling_cancel = gesture;

- fling_cancel.type = blink::WebInputEvent::GestureFlingCancel;

+ fling_cancel.setType(blink::WebInputEvent::GestureFlingCancel);

fling_cancel.sourceDevice = blink::WebGestureDeviceTouchscreen;

if (ShouldRouteEvent(event)) {

host_->delegate()->GetInputEventRouter()->RouteGestureEvent(