content/browser/renderer_host/input/mock_input_ack_handler.cc - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/mock_input_ack_handler.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/input/mock_input_ack_handler.cc

diff --git a/content/browser/renderer_host/input/mock_input_ack_handler.cc b/content/browser/renderer_host/input/mock_input_ack_handler.cc

index 3c499af139b66bc5b51bf7fdb7cc43de4352d6bf..32993722774206431bb56f79d3972b3fb2bb098a 100644

--- a/content/browser/renderer_host/input/mock_input_ack_handler.cc

+++ b/content/browser/renderer_host/input/mock_input_ack_handler.cc

@@ -31,7 +31,7 @@ void MockInputAckHandler::OnKeyboardEventAck(

const NativeWebKeyboardEventWithLatencyInfo& event,

InputEventAckState ack_result) {

VLOG(1) << __FUNCTION__ << " called!";

- acked_key_event_ = event.event;

+ acked_key_event_.reset(new NativeWebKeyboardEvent(event.event));

RecordAckCalled(event.event.type, ack_result);

}