chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/user_input_tracker_unittest.cc » ('j') | chrome/browser/page_load_metrics/user_input_tracker_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

index 4b42aa53f1288576abd3c0a7132babb5b936d9e8..03e1c5ec492e04810457e296f01399b0d2b91b60 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

@@ -38,8 +38,9 @@ class FromGWSPageLoadMetricsObserverTest

}

void SimulateMouseEvent() {

- blink::WebMouseEvent mouse_event;

- mouse_event.type = blink::WebInputEvent::MouseDown;

+ blink::WebMouseEvent mouse_event(blink::WebInputEvent::MouseDown,

+ blink::WebInputEvent::NoModifiers,

+ blink::WebInputEvent::TimeStampForTesting);

mouse_event.button = blink::WebMouseEvent::Button::Left;

mouse_event.x = 7;

mouse_event.y = 7;