Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

third_party/WebKit/public/platform/WebInputEvent.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 176 matching lines @@
 
     ScrollLockOn = 1 << 18,
 
     // The set of non-stateful modifiers that specifically change the
     // interpretation of the key being pressed. For example; IsLeft,
     // IsRight, IsComposing don't change the meaning of the key
     // being pressed. NumLockOn, ScrollLockOn, CapsLockOn are stateful
     // and don't indicate explicit depressed state.
     KeyModifiers =
         SymbolKey | FnKey | AltGrKey | MetaKey | AltKey | ControlKey | ShiftKey,
+    NoModifiers = 0,

[majidvp, 2016/12/19 20:09:52]

nit: Can we just have None = 0 and put it at the top and use
WebInputEvent::Modifiers::None and usage location? I feel this is cleaner and
does not lose any or the readability.

[dtapuska, 2016/12/20 19:49:21]

Done.

[majidvp, 2016/12/21 15:49:44]

I prefer these bitset values to be defined as const int and live 
outside of the enum. The enum is better be used to declare constant
bit flags instead. There is already InputModifiers that does this.

But this is not really related to this patch so lgtm.

   };
 
   // Indicates whether the browser needs to block on the ACK result for
   // this event, and if not why note (for metrics/diagnostics purposes).
   // These values are direct mappings of the values in PlatformEvent
   // so the values can be cast between the enumerations. static_asserts
   // checking this are in web/WebInputEventConversion.cpp.
   enum DispatchType {
     // Event can be canceled.
     Blocking,
@@ skipping 10 matching lines @@
   // expected to stick. If this axis is set to Free, then scrolling is not
   // stuck to any axis.
   enum RailsMode {
     RailsModeFree = 0,
     RailsModeHorizontal = 1,
     RailsModeVertical = 2,
   };
 
   static const int InputModifiers = ShiftKey | ControlKey | AltKey | MetaKey;
 
+  static constexpr double TimeStampForTesting = 123.0;
+

[majidvp, 2016/12/19 20:09:52]

Great idea to have a constant for testing.

[dtapuska, 2016/12/20 19:49:21]

Done.

   double timeStampSeconds;  // Seconds since platform start with microsecond
                             // resolution.
   unsigned size;            // The size of this structure, for serialization.
   Type type;
   int modifiers;
 
   // Returns true if the WebInputEvent |type| is a mouse event.
   static bool isMouseEventType(int type) {
     return MouseTypeFirst <= type && type <= MouseTypeLast;
   }
@@ skipping 20 matching lines @@
       return isGestureEventType(other.type);
     if (isTouchEventType(type))
       return isTouchEventType(other.type);
     if (isKeyboardEventType(type))
       return isKeyboardEventType(other.type);
     return type == other.type;
   }
 
   BLINK_COMMON_EXPORT static const char* GetName(WebInputEvent::Type);
 
+  void setType(Type typeParam) { type = typeParam; }
+
+  void setModifiers(int modifiersParam) { modifiers = modifiersParam; }
+
+  void setTimeStampSeconds(double seconds) { timeStampSeconds = seconds; }
+
  protected:
+  WebInputEvent(unsigned sizeParam,
+                Type typeParam,
+                int modifiersParam,
+                double timeStampSecondsParam) {
+    memset(this, 0, sizeParam);
+    timeStampSeconds = timeStampSecondsParam;
+    size = sizeParam;
+    type = typeParam;
+    modifiers = modifiersParam;
+  }
+
   explicit WebInputEvent(unsigned sizeParam) {
     memset(this, 0, sizeParam);
     timeStampSeconds = 0.0;
     size = sizeParam;
     type = Undefined;
-    modifiers = 0;

[majidvp, 2016/12/19 20:09:53]

why do you no longer not need to initialize modifiers? Is it because it is being
zeroed by memset?

[dtapuska, 2016/12/20 19:49:21]

yes it is an int and zeroed in the memset. I left the assignment for the others
because Undefined could change.

   }
 };
 
 // WebKeyboardEvent -----------------------------------------------------------
 
 class WebKeyboardEvent : public WebInputEvent {
  public:
   // Caps on string lengths so we can make them static arrays and keep
   // them PODs.
   static const size_t textLengthCap = 4;
@@ skipping 35 matching lines @@
 
   // |text| is the text generated by this keystroke.  |unmodifiedText| is
   // |text|, but unmodified by an concurrently-held modifiers (except
   // shift).  This is useful for working out shortcut keys.  Linux and
   // Windows guarantee one character per event.  The Mac does not, but in
   // reality that's all it ever gives.  We're generous, and cap it a bit
   // longer.
   WebUChar text[textLengthCap];
   WebUChar unmodifiedText[textLengthCap];
 
-  WebKeyboardEvent()
-      : WebInputEvent(sizeof(WebKeyboardEvent)),
-        windowsKeyCode(0),
-        nativeKeyCode(0),
-        isSystemKey(false),
-        isBrowserShortcut(false) {
-  }
+  WebKeyboardEvent(Type type, int modifiers, double timeStampSeconds)
+      : WebInputEvent(sizeof(WebKeyboardEvent),
+                      type,
+                      modifiers,
+                      timeStampSeconds) {}
+
+  WebKeyboardEvent() : WebInputEvent(sizeof(WebKeyboardEvent)) {}
 
   // Please refer to bug http://b/issue?id=961192, which talks about Webkit
   // keyboard event handling changes. It also mentions the list of keys
   // which don't have associated character events.
   bool isCharacterKey() const {
     // TODO(dtapuska): Determine if we can remove this method and just
     // not actually generate events for these instead of filtering them out.
     switch (windowsKeyCode) {
       case 0x08:  // VK_BACK
       case 0x1b:  // VK_ESCAPE
@@ skipping 18 matching lines @@
   int windowY;
 
   // Screen coordinate
   int globalX;
   int globalY;
 
   int movementX;
   int movementY;
   int clickCount;
 
+  WebMouseEvent(Type type, int modifiers, double timeStampSeconds)
+      : WebInputEvent(sizeof(WebMouseEvent), type, modifiers, timeStampSeconds),
+        WebPointerProperties() {}
+
   WebMouseEvent()
-      : WebInputEvent(sizeof(WebMouseEvent)),
-        WebPointerProperties(),
-        x(0),
-        y(0),
-        windowX(0),
-        windowY(0),
-        globalX(0),
-        globalY(0),
-        movementX(0),
-        movementY(0),
-        clickCount(0) {}
+      : WebInputEvent(sizeof(WebMouseEvent)), WebPointerProperties() {}
 
  protected:
   explicit WebMouseEvent(unsigned sizeParam)
-      : WebInputEvent(sizeParam),
-        WebPointerProperties(),
-        x(0),
-        y(0),
-        windowX(0),
-        windowY(0),
-        globalX(0),
-        globalY(0),
-        movementX(0),
-        movementY(0),
-        clickCount(0) {}
+      : WebInputEvent(sizeParam), WebPointerProperties() {}
+
+  WebMouseEvent(unsigned sizeParam,
+                Type type,
+                int modifiers,
+                double timeStampSeconds)
+      : WebInputEvent(sizeParam, type, modifiers, timeStampSeconds),
+        WebPointerProperties() {}
 };
 
 // WebMouseWheelEvent ---------------------------------------------------------
 
 class WebMouseWheelEvent : public WebMouseEvent {
  public:
   enum Phase {
     PhaseNone = 0,
     PhaseBegan = 1 << 0,
     PhaseStationary = 1 << 1,
@@ skipping 23 matching lines @@
 
   bool scrollByPage;
   bool hasPreciseScrollingDeltas;
 
   RailsMode railsMode;
 
   // Whether the event is blocking, non-blocking, all event
   // listeners were passive or was forced to be non-blocking.
   DispatchType dispatchType;
 
+  WebMouseWheelEvent(Type type, int modifiers, double timeStampSeconds)
+      : WebMouseEvent(sizeof(WebMouseWheelEvent),
+                      type,
+                      modifiers,
+                      timeStampSeconds),
+        deltaX(0.0f),
+        deltaY(0.0f),
+        wheelTicksX(0.0f),
+        wheelTicksY(0.0f),
+        accelerationRatioX(1.0f),
+        accelerationRatioY(1.0f),
+        resendingPluginId(-1),
+        phase(PhaseNone),
+        momentumPhase(PhaseNone),
+        railsMode(RailsModeFree),
+        dispatchType(Blocking) {}
+
   WebMouseWheelEvent()
       : WebMouseEvent(sizeof(WebMouseWheelEvent)),
         deltaX(0.0f),
         deltaY(0.0f),
         wheelTicksX(0.0f),
         wheelTicksY(0.0f),
         accelerationRatioX(1.0f),
         accelerationRatioY(1.0f),
         resendingPluginId(-1),
         phase(PhaseNone),
         momentumPhase(PhaseNone),
-        scrollByPage(false),
-        hasPreciseScrollingDeltas(false),
         railsMode(RailsModeFree),
         dispatchType(Blocking) {}
 };
 
 
 // WebTouchEvent --------------------------------------------------------------
 
 // TODO(e_hakkinen): Replace with WebPointerEvent. crbug.com/508283
 class WebTouchEvent : public WebInputEvent {
  public:
@@ skipping 16 matching lines @@
 
   // Whether this touch event is a touchstart or a first touchmove event per
   // scroll.
   bool touchStartOrFirstTouchMove;
 
   // A unique identifier for the touch event. Valid ids start at one and
   // increase monotonically. Zero means an unknown id.
   uint32_t uniqueTouchEventId;
 
   WebTouchEvent()
-      : WebInputEvent(sizeof(WebTouchEvent)),
-        touchesLength(0),
-        dispatchType(Blocking),
-        movedBeyondSlopRegion(false),
-        touchStartOrFirstTouchMove(false),
-        uniqueTouchEventId(0) {}
+      : WebInputEvent(sizeof(WebTouchEvent)), dispatchType(Blocking) {}
+
+  WebTouchEvent(Type type, int modifiers, double timeStampSeconds)
+      : WebInputEvent(sizeof(WebTouchEvent), type, modifiers, timeStampSeconds),
+        dispatchType(Blocking) {}
 };
 
 #pragma pack(pop)
 
 }  // namespace blink
 
 #endif