Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

content/browser/renderer_host/input/input_router_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/input_router_impl.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 15 matching lines @@
 #include "content/common/content_constants_internal.h"
 #include "content/common/edit_command.h"
 #include "content/common/input/synthetic_web_input_event_builders.h"
 #include "content/common/input/touch_action.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/mock_render_process_host.h"
 #include "content/public/test/test_browser_context.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/events/blink/web_input_event_traits.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 #if defined(USE_AURA)
 #include "content/browser/renderer_host/ui_events_helper.h"
 #include "ui/events/event.h"
 #endif
 
 using blink::WebGestureDevice;
 using blink::WebGestureEvent;
@@ skipping 31 matching lines @@
     static WebKeyboardEvent key;
     event = &key;
   } else if (WebInputEvent::isGestureEventType(type)) {
     static WebGestureEvent gesture;
     event = &gesture;
   } else if (type == WebInputEvent::MouseWheel) {
     static WebMouseWheelEvent wheel;
     event = &wheel;
   }
   CHECK(event);
-  event->type = type;
+  event->setType(type);
   return *event;
 }
 
 template<typename MSG_T, typename ARG_T1>
 void ExpectIPCMessageWithArg1(const IPC::Message* msg, const ARG_T1& arg1) {
   ASSERT_EQ(MSG_T::ID, msg->type());
   typename MSG_T::Schema::Param param;
   ASSERT_TRUE(MSG_T::Read(msg, &param));
   EXPECT_EQ(arg1, std::get<0>(param));
 }
@@ skipping 80 matching lines @@
         base::TimeDelta::FromMilliseconds(desktop_timeout_ms);
     config_.touch_config.mobile_touch_ack_timeout_delay =
         base::TimeDelta::FromMilliseconds(mobile_timeout_ms);
     config_.touch_config.touch_ack_timeout_supported = true;
     TearDown();
     SetUp();
     input_router()->NotifySiteIsMobileOptimized(false);
   }
 
   void SimulateKeyboardEvent(WebInputEvent::Type type) {
-    WebKeyboardEvent event = SyntheticWebKeyboardEventBuilder::Build(type);
-    NativeWebKeyboardEvent native_event;
-    memcpy(&native_event, &event, sizeof(event));
-    NativeWebKeyboardEventWithLatencyInfo key_event(native_event);
+    NativeWebKeyboardEventWithLatencyInfo key_event(
+        type, WebInputEvent::NoModifiers,
+        ui::EventTimeStampToSeconds(ui::EventTimeForNow()), ui::LatencyInfo());

[majidvp, 2016/12/19 20:09:52]

Any idea why the original logic was doing rather complicated dance of creating a
web keyboard event and using it to initialize a native event using memcpy? I
just want to make sure we are not missing some subtle 
behavior here. 

[dtapuska, 2016/12/20 19:49:21]

Because there wasn't a constructor on the NativeWebKeyboardEvent that took a
type in.

     input_router_->SendKeyboardEvent(key_event);
   }
 
   void SimulateWheelEvent(float x,
                           float y,
                           float dX,
                           float dY,
                           int modifiers,
                           bool precise) {
     input_router_->SendWheelEvent(MouseWheelEventWithLatencyInfo(
@@ skipping 2079 matching lines @@
   EXPECT_EQ(80, sent_event->data.flingStart.velocityY);
 
   const WebGestureEvent* filter_event =
       GetFilterWebInputEvent<WebGestureEvent>();
   TestLocationInFilterEvent(filter_event, orig);
   EXPECT_EQ(30, filter_event->data.flingStart.velocityX);
   EXPECT_EQ(40, filter_event->data.flingStart.velocityY);
 }
 
 }  // namespace content