Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 256923005: Remove chromium_2010_builder_tests target from all.gyp. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
bradnelson, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Remove chromium_2010_builder_tests target from all.gyp. This target was introduced in r80370 (https://codereview.chromium.org/6691035) for the migration of 2008 to msvs 2010. Since we are supporting only msvs 2013 nowadays and no buildbot scripts are using it we can remove it now. BUG=None TEST=green trybots R=scottmg@chromium.org,bradnelson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 8 months ago (2014-04-27 20:27:00 UTC) #1
scottmg
lgtm
6 years, 7 months ago (2014-04-28 16:14:39 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-04-30 01:33:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/256923005/1
6 years, 7 months ago (2014-04-30 01:35:44 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 10:50:50 UTC) #5
Message was sent while issue was closed.
Change committed as 267167

Powered by Google App Engine
This is Rietveld 408576698