Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256923003: Move service_discovery_client_impl.* into chrome/common. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Move service_discovery_client_impl.* into chrome/common. It's need to be used by utility and browser processes. BUG=349645 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266487

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sun 04/27/2014 11:39:04.49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1581 lines) Patch
D chrome/browser/local_discovery/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/test_service_discovery_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/local_discovery/local_domain_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/local_discovery/service_discovery_client_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/local_discovery/service_discovery_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/local_discovery/service_discovery_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/service_discovery_sniffer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/utility/local_discovery/local_domain_resolver_unittest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/utility/local_discovery/service_discovery_client_impl.h View 1 chunk +0 lines, -273 lines 0 comments Download
D chrome/utility/local_discovery/service_discovery_client_impl.cc View 1 chunk +0 lines, -584 lines 0 comments Download
D chrome/utility/local_discovery/service_discovery_client_unittest.cc View 1 chunk +0 lines, -518 lines 0 comments Download
M chrome/utility/local_discovery/service_discovery_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 8 months ago (2014-04-27 01:15:42 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-27 01:15:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256923003/20001
6 years, 8 months ago (2014-04-27 01:16:25 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-27 01:51:15 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-27 01:51:16 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/256923003/diff/20001/chrome/browser/local_discovery/service_discovery_client_mdns.cc File chrome/browser/local_discovery/service_discovery_client_mdns.cc (right): https://codereview.chromium.org/256923003/diff/20001/chrome/browser/local_discovery/service_discovery_client_mdns.cc#newcode9 chrome/browser/local_discovery/service_discovery_client_mdns.cc:9: #include "chrome/common/local_discovery/service_discovery_client_impl.h" not needed?
6 years, 8 months ago (2014-04-27 05:35:04 UTC) #6
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/256923003/diff/20001/chrome/browser/local_discovery/service_discovery_client_mdns.cc File chrome/browser/local_discovery/service_discovery_client_mdns.cc (right): https://codereview.chromium.org/256923003/diff/20001/chrome/browser/local_discovery/service_discovery_client_mdns.cc#newcode9 chrome/browser/local_discovery/service_discovery_client_mdns.cc:9: #include "chrome/common/local_discovery/service_discovery_client_impl.h" On 2014/04/27 05:35:04, Lei Zhang wrote: > ...
6 years, 8 months ago (2014-04-27 18:39:36 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-27 18:39:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256923003/40001
6 years, 8 months ago (2014-04-27 18:40:52 UTC) #9
commit-bot: I haz the power
Change committed as 266487
6 years, 7 months ago (2014-04-28 08:14:41 UTC) #10
Michael Achenbach
6 years, 7 months ago (2014-04-28 13:13:21 UTC) #11
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/250793011/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculating that this lead to a sizes
regression:
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linu...

Will reland otherwise..

Powered by Google App Engine
This is Rietveld 408576698