Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2569163002: Skip content duplication check at directory or selection scan. (Closed)

Created:
4 years ago by yamaguchi
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip content duplication check at directory or selection scan. The message is TBD. Skip content duplication check at the directory or selection scan, which runs automatically. After clicking the backup button, it starts full scan and then continues to copy detected files. In case of finding content duplication, it skips the transfer of such file but just marks as imported in the history. BUG=668574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Rebase on 2568723005 #

Patch Set 3 : Continue scan and import even when app window is closed. #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : Avoid recursive call of checkState to clarify execution path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -13 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/media_import_handler.js View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 2 3 4 5 7 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (12 generated)
yamaguchi
4 years ago (2016-12-20 02:19:07 UTC) #13
yamaguchi
4 years ago (2016-12-20 06:01:20 UTC) #14
I'll abandon this changelist, because we'd take a different approach.
The new changelist is here:
https://codereview.chromium.org/2594523002/

Powered by Google App Engine
This is Rietveld 408576698