third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py - Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/multiprocessing_bootstrap.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

index 82ea5018374f5d4b44a301765efa3162d84019c6..d5c918aa96df4f9e56a71c432c6046b760adb9b9 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

@@ -98,8 +98,7 @@ class MockExecutive(object):

args,

cwd=None,

input=None,

- # pylint: disable=W0613

- # unused argument

+ # pylint: disable=unused-argument

timeout_seconds=None,

error_handler=None,

return_exit_code=False,

@@ -206,7 +205,7 @@ class MockExecutive2(MockExecutive):

assert isinstance(args, list) or isinstance(args, tuple)

assert all(isinstance(arg, basestring) for arg in args)

if self._exception:

- raise self._exception # pylint: disable=E0702

+ raise self._exception # pylint: disable=raising-bad-type

if self._run_command_fn:

return self._run_command_fn(args)

if return_exit_code: