Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256913005: In browser process implementation of ServiceDiscoveryClient. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

In browser process implementation of ServiceDiscoveryClient. Front end runs on UI thread, network code runs on IO thread. BUG=349645 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266966

Patch Set 1 : Mon 04/28/2014 11:16:01.32 #

Patch Set 2 : Mon 04/28/2014 11:21:07.24 #

Total comments: 7

Patch Set 3 : Mon 04/28/2014 15:53:56.25 #

Total comments: 1

Patch Set 4 : Mon 04/28/2014 16:00:59.91 #

Patch Set 5 : Mon 04/28/2014 20:33:36.17 #

Patch Set 6 : #

Patch Set 7 : Tue 04/29/2014 14:32:52.76 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -14 lines) Patch
A + chrome/browser/local_discovery/service_discovery_client_mdns.h View 1 2 3 4 5 2 chunks +38 lines, -14 lines 0 comments Download
A chrome/browser/local_discovery/service_discovery_client_mdns.cc View 1 2 3 4 5 1 chunk +433 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-04-28 18:19:51 UTC) #1
Noam Samuel
https://codereview.chromium.org/256913005/diff/60001/chrome/browser/local_discovery/service_discovery_client_mdns.cc File chrome/browser/local_discovery/service_discovery_client_mdns.cc (right): https://codereview.chromium.org/256913005/diff/60001/chrome/browser/local_discovery/service_discovery_client_mdns.cc#newcode158 chrome/browser/local_discovery/service_discovery_client_mdns.cc:158: set_implementation(client()->CreateServiceWatcher( Do we want this created on the mdns ...
6 years, 7 months ago (2014-04-28 20:40:50 UTC) #2
Noam Samuel
lgtm
6 years, 7 months ago (2014-04-28 22:46:06 UTC) #3
Noam Samuel
On 2014/04/28 22:46:06, Noam Samuel wrote: > lgtm (Comments addressed offline)
6 years, 7 months ago (2014-04-28 22:46:28 UTC) #4
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/256913005/diff/60001/chrome/browser/local_discovery/service_discovery_client_mdns.cc File chrome/browser/local_discovery/service_discovery_client_mdns.cc (right): https://codereview.chromium.org/256913005/diff/60001/chrome/browser/local_discovery/service_discovery_client_mdns.cc#newcode158 chrome/browser/local_discovery/service_discovery_client_mdns.cc:158: set_implementation(client()->CreateServiceWatcher( Updated comment. On 2014/04/28 20:40:51, Noam Samuel wrote: ...
6 years, 7 months ago (2014-04-28 22:56:31 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-28 22:56:34 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-28 22:56:48 UTC) #7
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/256913005/diff/80001/chrome/browser/local_discovery/service_discovery_shared_client.cc File chrome/browser/local_discovery/service_discovery_shared_client.cc (right): https://codereview.chromium.org/256913005/diff/80001/chrome/browser/local_discovery/service_discovery_shared_client.cc#newcode48 chrome/browser/local_discovery/service_discovery_shared_client.cc:48: return new ServiceDiscoveryClientMdns(); Ugh, I didn't expect to enable ...
6 years, 7 months ago (2014-04-28 23:01:49 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 03:35:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256913005/130001
6 years, 7 months ago (2014-04-29 03:35:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 03:46:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-29 03:46:56 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 06:02:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256913005/150001
6 years, 7 months ago (2014-04-29 06:02:51 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 06:40:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 06:40:14 UTC) #16
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 07:06:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256913005/150001
6 years, 7 months ago (2014-04-29 07:06:39 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 07:19:05 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-29 07:19:05 UTC) #20
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 17:21:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256913005/150001
6 years, 7 months ago (2014-04-29 17:21:41 UTC) #22
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 21:33:19 UTC) #23
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 21:33:25 UTC) #24
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 21:33:36 UTC) #25
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 21:34:11 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/256913005/170001
6 years, 7 months ago (2014-04-29 21:35:58 UTC) #27
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 21:44:18 UTC) #28
Message was sent while issue was closed. 
Change committed as 266966

Powered by Google App Engine
This is Rietveld 408576698