Issue 2569113004: [css-align] Dedicated initial functions for {align-justify}-content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2569113004: [css-align] Dedicated initial functions for {align-justify}-content

Created:
4 years ago by jfernandez

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, mac-reviews_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[css-align] Dedicated initial functions for {align-justify}-content Since r419737 we use 'normal' as initial value for both, align-content and justify-content CSS properties. This may cause that such 'normal' values had to be resolved during layout, which apparently is causing a performance regression (2%) in some animation tests. This patch defines independent functions for both properties so we can use the specified values for each property, as the Flexbox spec states. BUG=649235

Patch Set 1 : Preliminary approach. #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -17 lines)			Patch
M	third_party/WebKit/Source/core/css/CSSProperties.in	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp	View	2 chunks	+49 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/ComputedStyle.h	View	2 chunks	+14 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #1 (id:1) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages