Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2569043002: Upgrade "path" package to 1.4.1 and eliminate analyzer test workaround. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index aa69a705e1edde35b3cc3b8e720a9cf8dfdbbc00..00bebad3fc7f9d51928d8331093df83625ef28c7 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -3447,14 +3447,11 @@ class D extends p.C {} // Prevent "unused import" warning
}
test_import_short_absolute() {
- if (resourceProvider.pathContext.separator == '\\') {
- // This test fails on Windows due to
- // https://github.com/dart-lang/path/issues/18
- // TODO(paulberry): reenable once that bug is addressed.
- return;
- }
testFile = '/my/project/bin/test.dart';
- addLibrarySource('/a.dart', 'class C {}');
+ // Note: "/a.dart" resolves differently on Windows vs. Posix.
+ var destinationPath =
+ resourceProvider.pathContext.fromUri(Uri.parse('/a.dart'));
+ addLibrarySource(destinationPath, 'class C {}');
checkLibrary('import "/a.dart"; C c;');
}
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698