third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp - Issue 2569013006: Changed EOverflow to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2569013006: Changed EOverflow to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

index fc80cc42c085f3105dc91a4ed15fe70f42bccf71..648ff5a06290b99b0985eaf66b91a6a6f91a9dca 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

@@ -1216,7 +1216,7 @@ LayoutUnit LayoutFlexibleBox::adjustChildSizeForMinAndMax(

// percentage min size, but we have an indefinite size in that axis.

minExtent = std::max(LayoutUnit(), minExtent);

} else if (min.isAuto() && !child.styleRef().containsSize() &&

- mainAxisOverflowForChild(child) == OverflowVisible &&

+ mainAxisOverflowForChild(child) == EOverflow::Visible &&

!(isColumnFlow() && child.isFlexibleBox())) {

// TODO(cbiesinger): For now, we do not handle min-height: auto for nested

// column flexboxes. We need to implement