Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2569013002: Fix hot reload test mode in simdbc by supporting forced slow paths on simdbc (Closed)

Created:
4 years ago by Cutch
Modified:
4 years ago
Reviewers:
zra, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix hot reload test mode in simdbc by supporting forced slow paths on simdbc - [x] Add new SIM DBC byte code: CheckStackAlwaysExit. - [x] Emit CheckStackAlwaysExit instead of CheckStack when requested. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8b6f6102062a772d2f9f6bff8c86ac3565fb0cd2

Patch Set 1 #

Patch Set 2 : Fix exit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M runtime/vm/constants_dbc.h View 1 chunk +1 line, -0 lines 1 comment Download
M runtime/vm/intermediate_language_dbc.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years ago (2016-12-12 21:14:46 UTC) #3
rmacnak
lgtm
4 years ago (2016-12-12 22:06:17 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as 8b6f6102062a772d2f9f6bff8c86ac3565fb0cd2 (presubmit successful).
4 years ago (2016-12-12 22:07:28 UTC) #6
zra
4 years ago (2016-12-12 22:07:37 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2569013002/diff/20001/runtime/vm/constants_dbc.h
File runtime/vm/constants_dbc.h (right):

https://codereview.chromium.org/2569013002/diff/20001/runtime/vm/constants_db...
runtime/vm/constants_dbc.h:824: V(CheckStackAlwaysExit,            0, ___, ___,
___) \
Maybe CheckStackAlwaysCall?

Please add docs in the comment above.

Powered by Google App Engine
This is Rietveld 408576698