chrome/browser/policy/cloud/device_management_service_browsertest.cc - Issue 25690003: Refactored the DeviceManagementService to get its parameters from a delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/device_management_service_browsertest.cc

Issue 25690003: Refactored the DeviceManagementService to get its parameters from a delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/device_management_service.cc ('k') | chrome/browser/policy/cloud/device_management_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/device_management_service_browsertest.cc

diff --git a/chrome/browser/policy/cloud/device_management_service_browsertest.cc b/chrome/browser/policy/cloud/device_management_service_browsertest.cc

index 0e28e8600f0448ee201064ed3814ec0c12a1d456..478629d2a23ee079d070a151cdf41bb7acf1c4a9 100644

--- a/chrome/browser/policy/cloud/device_management_service_browsertest.cc

+++ b/chrome/browser/policy/cloud/device_management_service_browsertest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/policy/cloud/cloud_policy_constants.h"

#include "chrome/browser/policy/cloud/device_management_service.h"

+#include "chrome/browser/policy/cloud/mock_device_management_service.h"

#include "chrome/browser/policy/cloud/test_request_interceptor.h"

#include "chrome/browser/policy/test/local_policy_test_server.h"

#include "chrome/test/base/in_process_browser_test.h"

@@ -140,11 +141,9 @@ class DeviceManagementServiceIntegrationTest

virtual void SetUpOnMainThread() OVERRIDE {

std::string service_url((this->*(GetParam()))());

service_.reset(new DeviceManagementService(

- g_browser_process->system_request_context(),

- service_url,

- "UserAgent",

- "UserAgentParam",

- "PlatformParam"));

+ scoped_ptr<DeviceManagementService::Configuration>(

+ new MockDeviceManagementServiceConfiguration(service_url)),

+ g_browser_process->system_request_context()));

service_->ScheduleInitialization(0);

}